[CCXDEV-11808] Remove all the f-strings from the exceptions #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juandspy
requested review from
tisnik,
Bee-lee,
joselsegura,
dpensi,
matysek,
epapbak and
JiriPapousek
as code owners
juandspy
changed the title
joselsegura
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using f-strings in Exceptions is an anti pattern - see https://docs.astral.sh/ruff/rules/f-string-in-exception/ for example. This is creating a lot of duplication in Glitchtip making it impossible to integrate it with Jira. It will basically DDOS our Jira board.
In this PR I remove all the f-strings from the exceptions. I left the Exceptions in
parse_human_filesizeas the arguments there are not dynamically generated, but it could be dropped too.Part of CCXDEV-11808
Type of change
Testing steps
CI.
Checklist
make before_commitpasses