[CCXDEV-11808] Don't set CCXMessagingErrors value directly from parent #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juandspy
requested review from
tisnik,
Bee-lee,
joselsegura,
dpensi,
matysek,
epapbak and
JiriPapousek
as code owners
Bee-lee
approved these changes
Dec 11, 2023
epapbak
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This exception was causing events like this one. We shouldn't instantiate the CCXMessagingError directly from the parent exception.
Type of change
Testing steps
CI
Checklist
make before_commitpasses