Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New S3 downloader for internal-data-pipeline #155

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

Jakub007d
Copy link
Contributor

Description

We cant use the default insights messaging S3 downloader because we need to put bucket name into the path name hence the creation of simple modification of this downloader is needed.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Testing steps

Tested localy

Checklist

  • make before_commit passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 82.30%. Comparing base (7d5b41b) to head (10a3382).

Files Patch % Lines
ccx_messaging/downloaders/s3_downloader.py 82.60% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   82.29%   82.30%           
=======================================
  Files          27       28    +1     
  Lines         819      842   +23     
=======================================
+ Hits          674      693   +19     
- Misses        145      149    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JiriPapousek
Copy link
Collaborator

Add copyright header and spacings between import and docstring (e.g. like here: https://gitlab.cee.redhat.com/service/app-interface/-/merge_requests/99061)

@Jakub007d
Copy link
Contributor Author

Fixed

Copy link
Collaborator

@joselsegura joselsegura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks to take a look into it. Please, use pre-commit hook locally to format the code according to our "code style"

Please, add some unit test, as the code is pretty small it won't take too much

@joselsegura joselsegura force-pushed the new-downloader branch 2 times, most recently from e67cb5a to bfac38e Compare March 12, 2024 12:07
@Jakub007d Jakub007d merged commit e8d67a4 into RedHatInsights:main Mar 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants