Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCXDEV-12259] New publisher for archive sync #159

Merged
merged 14 commits into from
Mar 13, 2024
Merged

Conversation

Jakub007d
Copy link
Contributor

Description

New publisher for achive sync

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Unit tests (no changes in the code)

Testing steps

Tested localy

Checklist

  • make before_commit passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 82.29%. Comparing base (616d91f) to head (46d74c2).
Report is 7 commits behind head on main.

Files Patch % Lines
...x_messaging/publishers/synced_archive_publisher.py 50.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
- Coverage   82.93%   82.29%   -0.65%     
==========================================
  Files          26       27       +1     
  Lines         803      819      +16     
==========================================
+ Hits          666      674       +8     
- Misses        137      145       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jakub007d Jakub007d requested a review from juandspy March 12, 2024 10:09
ccx_messaging/publishers/idp_publisher.py Outdated Show resolved Hide resolved
test/publishers/idp_publisher_test.py Outdated Show resolved Hide resolved
@joselsegura
Copy link
Collaborator

If you can, please rebase your changes in top of main branch. I changed the CI configuration and it's worth to run the new CI pipelines for your commit too

@Jakub007d Jakub007d requested a review from joselsegura March 13, 2024 12:14
@Jakub007d Jakub007d merged commit 7d5b41b into main Mar 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants