Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #160

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

joselsegura
Copy link
Collaborator

Description

Some dependencies problems arisen with newer versions of s3fs/aiobotocore/boto3 madness. I set a more strict dependency version, that allow us to have a newer boto3/botocore versions that we already had pinned

Type of change

  • Bump-up dependent library (no changes in the code)

Testing steps

tested locally, installing in virtualenv and running tests with tox for different Python versions

Checklist

  • make before_commit passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.93%. Comparing base (616d91f) to head (a668a7e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #160   +/-   ##
=======================================
  Coverage   82.93%   82.93%           
=======================================
  Files          26       26           
  Lines         803      803           
=======================================
  Hits          666      666           
  Misses        137      137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joselsegura joselsegura merged commit 72c5b43 into RedHatInsights:main Mar 12, 2024
6 checks passed
@joselsegura joselsegura deleted the update_deps branch March 12, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants