-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OCP Engine with filter for OLS tarballx #197
Conversation
a323788
to
3031c75
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
==========================================
+ Coverage 84.69% 85.00% +0.31%
==========================================
Files 33 34 +1
Lines 1078 1114 +36
==========================================
+ Hits 913 947 +34
- Misses 165 167 +2 ☔ View full report in Codecov by Sentry. |
18bab9e
to
082594a
Compare
The OLS team announced today that they will be starting to send their archives with a different User-Agent. If it is possible, probably we can filter them out because the service header, so please wait until tomorrow before merging and using this engine. |
I'm not 100% sure tomorrow they'll have a different service header that we will be able to use, but it makes sense to wait and see indeed. |
Description
OCPEngine
, which is basically the ICM engine with a filter for whenopenshift_lightspeed.json
file is found in ht tarball's root directory.ols
label value in StatsWatcher, so that metrics are updated with theols
archive type when possibleCons of this approach: Our OCP engine used to use be the ICM engine, used directly. We now lose the updates made there if the
process
method is ever updated. But this is supposed to be temporary, so let's not delve on that.Fixes CCXDEV-12725 partially (config update needed in ccx-data-pipeline)
Type of change
Testing steps
Updated UTs
Checklist
pre-commit run -a
passes