Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ccx_consumer_archive_size counter #201

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

epapbak
Copy link
Collaborator

@epapbak epapbak commented Apr 22, 2024

Description

  • Refactor StatsWatcher to cache archive type and size for each receive archive
  • When archive is downloaded, the size of the extracted archive is cached
  • When the archive is extracted, the type of archive is determined and cached
  • ccx_consumer_archive_size counter is updated when the above information is available for an archive

(I made it this way to not touch the ocp_engine.py file, which we might remove in the future)

Fixes CCXDEV-12521

Type of change

  • New feature (non-breaking change which adds functionality)

Testing steps

Updated and added UTs

Checklist

  • pre-commit run -a passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 85.01%. Comparing base (e07fc58) to head (e2fe0fe).
Report is 6 commits behind head on main.

Files Patch % Lines
ccx_messaging/watchers/stats_watcher.py 76.92% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   85.00%   85.01%           
=======================================
  Files          34       34           
  Lines        1114     1121    +7     
=======================================
+ Hits          947      953    +6     
- Misses        167      168    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@epapbak epapbak changed the title Ccxdev 12521 Add ccx_consumer_archive_size counter Apr 22, 2024
@epapbak epapbak marked this pull request as ready for review April 22, 2024 09:44
@epapbak epapbak merged commit 0c29188 into RedHatInsights:main Apr 22, 2024
8 checks passed
@epapbak epapbak deleted the CCXDEV-12521 branch April 26, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants