Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ACL permissions to every uploaded archive #203

Merged

Conversation

joselsegura
Copy link
Collaborator

@joselsegura joselsegura commented Apr 23, 2024

Description

Make the S3 uploader, by default, to allow the bucket owner to access the uploaded files. By default, in ACL-configured buckets, the ACL doesn't allow the owner of the bucket to read the objects.

Fixes CCXDEV-12771

Type of change

  • Refactor (refactoring code, removing useless files)

Testing steps

Added some unit tests. Tested locally

Checklist

  • pre-commit run -a passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • [-] updated schemas and validators in insights-data-schemas in case of input/output change

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.03%. Comparing base (a3ca9d3) to head (bf9b42a).

Files Patch % Lines
ccx_messaging/utils/s3_uploader.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
+ Coverage   85.01%   85.03%   +0.02%     
==========================================
  Files          34       34              
  Lines        1121     1116       -5     
==========================================
- Hits          953      949       -4     
+ Misses        168      167       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@epapbak epapbak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned, if you could split the change and the formatting into two separate commits, that'd be appreciated =)

@joselsegura joselsegura force-pushed the s3_uploader_configurable branch from 75b98c6 to bf9b42a Compare April 23, 2024 12:16
@joselsegura
Copy link
Collaborator Author

Splitted. I didn´t realise that pre-commit did so many changes

@joselsegura joselsegura merged commit 102a408 into RedHatInsights:main Apr 23, 2024
8 checks passed
@joselsegura joselsegura deleted the s3_uploader_configurable branch April 23, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants