Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCXDEV-12772: S3UploadEngine compatible with KafkaConsumer #207

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

joselsegura
Copy link
Collaborator

Description

Refactor of the previous PR for adapting the engine to be used with several consumers.
Added unit tests for the IDPConsumer class, that didn´t have any

Fixes #CCXDEV'12772

Type of change

  • Refactor (refactoring code, removing useless files)
  • Unit tests (no changes in the code)

Testing steps

Please describe how the change was tested locally. If, for some reason, the testing was not done or not done fully, please describe what are the testing steps.

Checklist

  • pre-commit run -a passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.23%. Comparing base (c14ccbd) to head (23a3a0d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
+ Coverage   85.03%   88.23%   +3.19%     
==========================================
  Files          34       34              
  Lines        1116     1139      +23     
==========================================
+ Hits          949     1005      +56     
+ Misses        167      134      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joselsegura joselsegura merged commit d6a2d10 into RedHatInsights:main Apr 29, 2024
8 checks passed
@joselsegura joselsegura deleted the ccxdev-12772 branch April 29, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants