Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning an expected value #219

Merged
merged 1 commit into from
May 13, 2024

Conversation

joselsegura
Copy link
Collaborator

Description

OCPEngine returns None, which is an unexpected value for the publishers as "report" value, when an archive is filtered out.

Instead of None, returning an empty dict will allow the publishers to handle it properly

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing steps

Only local test

Checklist

  • pre-commit run -a passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.38%. Comparing base (ad2298d) to head (cda1385).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   85.38%   85.38%           
=======================================
  Files          34       34           
  Lines        1197     1197           
=======================================
  Hits         1022     1022           
  Misses        175      175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joselsegura joselsegura merged commit 6026728 into RedHatInsights:main May 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants