Fix-on-fix error in return type for OCP Engine #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joselsegura
requested review from
Bee-lee,
matysek,
epapbak,
JiriPapousek,
juandspy and
Jakub007d
as code owners
epapbak
approved these changes
May 13, 2024
matysek
approved these changes
May 13, 2024
JiriPapousek
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous fix was wrong, as the returned value should be an string or bytes-like objects containing a serialized JSON
Type of change
Testing steps
Tested locally with unit tests and small manual integration test
Checklist
pre-commit run -apasses