Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update pr_check.sh to deploy the archive-sync on ephemeral" #228

Merged
merged 1 commit into from
May 29, 2024

Conversation

epapbak
Copy link
Collaborator

@epapbak epapbak commented May 29, 2024

Reverts #215

The archive-sync component doesn't exist, and there's no service we deploy directly using ccx-messaging right now.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.77%. Comparing base (a49ab0e) to head (4cd89af).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
- Coverage   86.10%   85.77%   -0.33%     
==========================================
  Files          34       28       -6     
  Lines        1209     1181      -28     
==========================================
- Hits         1041     1013      -28     
  Misses        168      168              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@joselsegura joselsegura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but I would wait for Juan's review, as owner of the commit you're reverting. Maybe we are losing some point for this PR check

@epapbak
Copy link
Collaborator Author

epapbak commented May 29, 2024

I agree, but I would wait for Juan's review, as owner of the commit you're reverting. Maybe we are losing some point for this PR check

that's the idea =)

@epapbak epapbak merged commit e075476 into main May 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants