Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove initializer for OCPEngine #380

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

joselsegura
Copy link
Collaborator

Description

The initializer for OCPEngine class is not needed, as it only calls to its parent initializer. It was causing some problems when using newer versions of ICM and configuring this engine.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing steps

Tested locally

Checklist

  • pre-commit run -a passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.79%. Comparing base (3c62e61) to head (b9ddb9d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
- Coverage   85.82%   85.79%   -0.03%     
==========================================
  Files          28       28              
  Lines        1199     1197       -2     
==========================================
- Hits         1029     1027       -2     
  Misses        170      170              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joselsegura joselsegura enabled auto-merge January 9, 2025 14:54
@joselsegura
Copy link
Collaborator Author

/retest

2 similar comments
@joselsegura
Copy link
Collaborator Author

/retest

@joselsegura
Copy link
Collaborator Author

/retest

@joselsegura joselsegura merged commit 1203b57 into RedHatInsights:main Jan 13, 2025
9 checks passed
@joselsegura joselsegura deleted the fix_ocp_engine branch January 13, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants