Cleanup linters and CI tools #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joselsegura
force-pushed
the
linters_cleanup
branch
3 times, most recently
from
2101f25 to
863b5de
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
==========================================
+ Coverage 85.82% 85.92% +0.10%
==========================================
Files 28 30 +2
Lines 1199 1265 +66
==========================================
+ Hits 1029 1087 +58
- Misses 170 178 +8 ☔ View full report in Codecov by Sentry. |
joselsegura
force-pushed
the
linters_cleanup
branch
from
863b5de to
6c32da6
Compare
juandspy
reviewed
Jan 13, 2025
juandspy
reviewed
Jan 13, 2025
ikerreyes
approved these changes
Jan 13, 2025
joselsegura
force-pushed
the
linters_cleanup
branch
from
6c32da6 to
c9bc9de
Compare
juandspy
approved these changes
Jan 13, 2025
- black was not used for ages in CI, ruff can be used for formatting too - flake8 is overseeded by ruff - pydocstyle was deprecated in favour of ruff, that we are already using. - Creating a new category of optional deps for testing - Fix ruff configuration warning - Adding ruff to pre-commit, just check - Adapted tox configuration
joselsegura
force-pushed
the
linters_cleanup
branch
from
c9bc9de to
69c9b58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Testing steps
Tested locally with pre-commit
Checklist
pre-commit run -apasses