Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New publisher for internal data pipeline rule processor #388

Merged

Conversation

joselsegura
Copy link
Collaborator

Description

Adding a new publisher to be used in the Internal Data Pipeline Rules processing service.

Fixes #CCXDEV-12596

Type of change

  • New feature (non-breaking change which adds functionality)

Testing steps

Added new tests for the new class.

Checklist

  • pre-commit run -a passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.04%. Comparing base (77a0c6c) to head (4744ad5).

Files with missing lines Patch % Lines
...saging/publishers/idp_rule_processing_publisher.py 92.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
+ Coverage   85.92%   86.04%   +0.11%     
==========================================
  Files          30       31       +1     
  Lines        1265     1290      +25     
==========================================
+ Hits         1087     1110      +23     
- Misses        178      180       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joselsegura joselsegura force-pushed the new_publisher_processing_rules branch from c437dbb to c406428 Compare January 13, 2025 15:25
@joselsegura joselsegura requested a review from juandspy January 13, 2025 15:35
@joselsegura joselsegura force-pushed the new_publisher_processing_rules branch from c406428 to 4744ad5 Compare January 13, 2025 16:39
@joselsegura joselsegura enabled auto-merge January 14, 2025 07:07
@joselsegura joselsegura merged commit 2ff1cf3 into RedHatInsights:main Jan 14, 2025
11 checks passed
@joselsegura joselsegura deleted the new_publisher_processing_rules branch January 14, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants