Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Kafka clowder configuration injection #50

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

joselsegura
Copy link
Collaborator

Description

The Clowder configuration is able to inject new Kafka broker configuration parameters. This change intends to unify the way that it is handled (making it non dependent on the Kafka library used by the components).

It also adapts the current Kafka-related components in order to use the new approach.

This is very helpful to perform the needed changes for Confluent Kafka migration

Type of change

  • Refactor (refactoring code, removing useless files)

Testing steps

Just locally, going to test in ephemeral (I need a PR for that)

Checklist

  • make before_commit passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2023

Codecov Report

Patch coverage: 70.58% and project coverage change: +0.51 🎉

Comparison is base (968cf71) 83.61% compared to head (0e9eb88) 84.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   83.61%   84.13%   +0.51%     
==========================================
  Files          21       21              
  Lines         702      731      +29     
==========================================
+ Hits          587      615      +28     
- Misses        115      116       +1     
Impacted Files Coverage Δ
ccx_messaging/utils/clowder.py 0.00% <0.00%> (ø)
ccx_messaging/consumers/kafka_consumer.py 82.64% <70.00%> (-0.98%) ⬇️
...cx_messaging/publishers/data_pipeline_publisher.py 94.11% <90.00%> (-1.34%) ⬇️
ccx_messaging/consumers/consumer.py 88.43% <100.00%> (+1.30%) ⬆️
ccx_messaging/publishers/sha_publisher.py 97.91% <100.00%> (+0.24%) ⬆️
ccx_messaging/utils/kafka_config.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@joselsegura joselsegura force-pushed the improve_clowder_config_injection branch from 3463f1b to 1313d3f Compare March 22, 2023 12:45
Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all right!!

Copy link
Collaborator

@epapbak epapbak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@joselsegura joselsegura merged commit f1d40b6 into main Mar 22, 2023
@joselsegura joselsegura deleted the improve_clowder_config_injection branch March 22, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants