Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python 3.6 compatible Confluent version #51

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

joselsegura
Copy link
Collaborator

Description

There is an issue in Confluent Kafka that prevent to use the latest version in Python 3.6, at least in Red Hat based systems.

This commit ensures that the Confluent version is compatible with Python 3.6, currently used by some of the services using this library.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing steps

N/A

Checklist

  • make before_commit passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (f1d40b6) 84.26% compared to head (30b7576) 84.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   84.26%   84.26%           
=======================================
  Files          21       21           
  Lines         737      737           
=======================================
  Hits          621      621           
  Misses        116      116           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh :) ok!

@joselsegura joselsegura merged commit 339a65c into main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants