Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher of rule processing reports using Confluent #52

Merged
merged 2 commits into from
Mar 24, 2023

Conversation

joselsegura
Copy link
Collaborator

Description

Added new "publisher" to the library, sending rule processing reports to Kafka using Confluent Kafka lib instead of current kafka-python

Type of change

  • New feature (non-breaking change which adds functionality)
  • Unit tests (no changes in the code)
  • Bump-up dependent library (no changes in the code)

Testing steps

Smoke tests using this version in ccx-data-pipeline repository (https://gitlab.cee.redhat.com/ccx/ccx-data-pipeline/-/pipelines/3475282). Tested in ephemeral env

Checklist

  • make before_commit passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.96 🎉

Comparison is base (339a65c) 84.26% compared to head (30a8518) 85.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   84.26%   85.22%   +0.96%     
==========================================
  Files          21       22       +1     
  Lines         737      785      +48     
==========================================
+ Hits          621      669      +48     
  Misses        116      116              
Impacted Files Coverage Δ
..._messaging/publishers/rule_processing_publisher.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@joselsegura joselsegura merged commit 981da31 into main Mar 24, 2023
@joselsegura joselsegura deleted the add_confluent_publisher branch March 24, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants