fix: add filter to dependency datasource only #3949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangce
force-pushed
the
filter_component
branch
from
5e65aad to
5a7dc63
Compare
JoySnow
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Just saw this MR, and made some tests in my local. This fix works as expected. @xiangce, 👍 .
# adding filters:
add_filter(Specs.yum_log, 'Add filter to Specs.yum_log')
add_filter(DefaultSpecs.yum_log, 'Add filter to DefaultSpecs.yum_log')
add_filter(YumLog, 'Add filter to parsers.yumlog.YumLog')
# generated "insights/filters.yaml":
...
insights.specs.Specs.yum_log:
- Add filter to Specs.yum_log
- Add filter to parsers.yumlog.YumLog
- 'Erased:'
- 'Installed:'
- 'Updated:'
insights.specs.default.DefaultSpecs.yum_log:
- Add filter to DefaultSpecs.yum_log
xiangce
added a commit
that referenced
this pull request
Nov 14, 2023
- when add_filter to component (parser or combiner), add the filters to the datasource on which the component directly depends - add relevant tests Signed-off-by: Xiangce Liu <xiangceliu@redhat.com> (cherry picked from commit 26abad6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the filters to the datasource that the component
actually depends on
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes: