fix: Enhance spec "satellite_settings" and parser to support satellite 6.14 #3952
Conversation
insights/components/satellite.py
Outdated
| SkipComponent: When the Satellite version is earlier than 6.14. | ||
| """ | ||
| def __init__(self, sat): | ||
| if sat.major == 6 and sat.minor < 14: |
There was a problem hiding this comment.
Hi @huali027 , the code looks good to me. Jut one concern here.
I am new to Satellite things, and just from the code, I guess that a "Satellite 5.x" will also hit this IsSatellite614AndLater component.
Do we process only "Satellite 6" systems, or something are already be done to assured for this.
There was a problem hiding this comment.
@JoySnow From previous statistics, only 5 satellite 5.x hosts on production now. In fact, in our rule, we only support the satellite versions which are supported now, like 6.11, 6.12, 6.13, 6.14, and 6.11 will be expired soon. Normally three versions are supported.
But if I limit the version here, I should update it from time to time. So I don't add more limitation. If the command doesn't work on some versions, it just fails to get the result.
There was a problem hiding this comment.
Thanks @huali027 , the code looks good to me .
…e 6.14 * Since satellite 6.14, the column "default" has been deleted from satellite_settings table. Signed-off-by: Huanhuan Li <huali@redhat.com>
* Exclude satellite 5.x Signed-off-by: Huanhuan Li <huali@redhat.com>
Signed-off-by: Huanhuan Li <huali@redhat.com>
…e 6.14 (#3952) * fix: Enhance spec "satellite_settings" and parser to support satellite 6.14 - Since satellite 6.14, the column "default" has been deleted from satellite_settings table. Signed-off-by: Huanhuan Li <huali@redhat.com> * Exclude satellite 5.x * Add parenthese to make statement more clear Signed-off-by: Huanhuan Li <huali@redhat.com> (cherry picked from commit 50b8ce9)
All Pull Requests:
Check all that apply: