Skip to content
This repository has been archived by the owner on Aug 14, 2019. It is now read-only.

Remove default actions from inventory header, add edit actions to general tab #419

Merged
merged 3 commits into from
May 16, 2019

Conversation

karelhala
Copy link
Contributor

This PR updates 2 things

  • Move edit actions to general tab
  • Add operating system info

Before

Screenshot from 2019-05-02 14-25-47
Screenshot from 2019-05-02 14-25-54

After

Screenshot from 2019-05-02 14-23-20
Screenshot from 2019-05-02 14-23-14

@karelhala karelhala requested a review from ryelo May 2, 2019 12:26
@karelhala karelhala force-pushed the properties-updates branch from 143d1a1 to c866e67 Compare May 2, 2019 12:30
@bclarhk
Copy link

bclarhk commented May 2, 2019

UUID and Last seen should be left aligned with the system name
The edit icon (pencil) is missing any padding. I believe it should have 8 px padding.
Last boot time should follow the same date formatting as Last check-in and Registered

@karelhala karelhala force-pushed the properties-updates branch from c866e67 to 2d7cfc5 Compare May 3, 2019 13:57
@codecov-io
Copy link

codecov-io commented May 3, 2019

Codecov Report

Merging #419 into master will decrease coverage by 0.22%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
- Coverage   26.57%   26.35%   -0.23%     
==========================================
  Files         131      131              
  Lines        1915     1931      +16     
  Branches      338      338              
==========================================
  Hits          509      509              
- Misses       1141     1157      +16     
  Partials      265      265
Impacted Files Coverage Δ
...ry/applications/general-information/LoadingCard.js 0% <ø> (ø) ⬆️
src/SmartComponents/Inventory/TextInputModal.js 0% <ø> (ø) ⬆️
...ications/general-information/GeneralInformation.js 0% <ø> (ø) ⬆️
...lications/general-information/ConfigurationCard.js 0% <0%> (ø) ⬆️
...tory/applications/general-information/selectors.js 0% <0%> (ø) ⬆️
src/SmartComponents/Inventory/EntityDetail.js 0% <0%> (ø) ⬆️
...ory/applications/general-information/SystemCard.js 0% <0%> (ø) ⬆️
...cations/general-information/OperatingSystemCard.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9eda01...0d95f2b. Read the comment docs.

@karelhala
Copy link
Contributor Author

@bclarhk thanks for the updates. Here is updated screenshot
Screenshot from 2019-05-03 15-55-59

@karelhala karelhala merged commit 780f018 into RedHatInsights:master May 16, 2019
@karelhala
Copy link
Contributor Author

🎉 This PR is included in version 3.41.65 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants