Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHINENG-7611: Add bootc_status #123

Merged
merged 2 commits into from
Jan 19, 2024
Merged

RHINENG-7611: Add bootc_status #123

merged 2 commits into from
Jan 19, 2024

Conversation

JoySnow
Copy link
Contributor

@JoySnow JoySnow commented Jan 18, 2024

@JoySnow
RHINENG-7611: Add bootc_status
711b174 
Signed-off-by: Xiaoxue Wang <xiaoxwan@redhat.com>
@JoySnow JoySnow requested a review from a team as a code owner January 18, 2024 03:57
@JoySnow JoySnow marked this pull request as draft January 18, 2024 04:00
@JoySnow
fix the lint errors in CI check
90cc4e3 
Signed-off-by: Xiaoxue Wang <xiaoxwan@redhat.com>
@JoySnow JoySnow marked this pull request as ready for review January 18, 2024 07:01
@dippy-bot
Copy link
Collaborator

Here are the System Profile validation results using Prod data.
Validating against the RedHatInsights/inventory-schemas master spec:

yupana:
	Pass: 299447
	Fail: 1

rhsm-system-profile-bridge:
	Pass: 19070
	Fail: 0

puptoo:
	Pass: 160633
	Fail: 3

cloud-connector:
	Pass: 1275
	Fail: 0

rhsm-conduit:
	Pass: 19571
	Fail: 0

Validating against this PR's spec:

yupana:
	Pass: 299447
	Fail: 1

rhsm-system-profile-bridge:
	Pass: 19070
	Fail: 0

puptoo:
	Pass: 160633
	Fail: 3

cloud-connector:
	Pass: 1275
	Fail: 0

rhsm-conduit:
	Pass: 19571
	Fail: 0

kruai
kruai approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@kruai kruai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kruai
Copy link
Contributor

kruai commented Jan 18, 2024

@JoySnow Based on the linked Jira, I think this looks good. Is it OK if I merge it now?

beav
beav reviewed Jan 18, 2024
View reviewed changes
schemas/system_profile/v1.yaml
image:
description: Name of the image
type: string
example: "quay.io/centos-bootc/fedora-bootc-cloud:eln, 192.168.0.1:5000/foo/foo:latest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is two examples separated by comma, not one. Sorry for the confusion

beav
beav reviewed Jan 18, 2024
View reviewed changes
schemas/system_profile/v1.yaml
image_digest:
description: Digest of the image
type: string
example: "sha256:806d77394f96e47cf99b1233561ce970c94521244a2d8f2affa12c3261961223, sha256:92e476435ced1c148350c660b09c744717defbd300a15d33deda5b50ad6b21a0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also two examples, same as above

@JoySnow
Copy link
Contributor Author

JoySnow commented Jan 19, 2024

Thanks for the note, @beav .

And, thanks for the review, @kruai , @FabriciaDinizRH .

I am okay to merge this PR.

@JoySnow JoySnow mentioned this pull request Jan 19, 2024
Merged
@kruai kruai merged commit df89674 into RedHatInsights:master Jan 19, 2024
1 of 2 checks passed
@JoySnow JoySnow deleted the add-bootc_status branch January 19, 2024 16:06
@kruai
Copy link
Contributor

kruai commented Jan 19, 2024

FYI, I'm seeing some downstream issues related to this; I'm currently debugging and may need to tweak things a little bit.

@kruai kruai mentioned this pull request Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beav beav beav left review comments

@FabriciaDinizRH FabriciaDinizRH FabriciaDinizRH approved these changes

@kruai kruai kruai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JoySnow @dippy-bot @kruai @beav @FabriciaDinizRH