RHCLOUD-34728 | feature: authentication on the Kessel clients #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikelAlejoBR
force-pushed
the
RHCLOUD-34728-kessel-clients-authorization
branch
3 times, most recently
from
c083261
to
42c08c0
Compare
MikelAlejoBR
force-pushed
the
RHCLOUD-34728-kessel-clients-authorization
branch
2 times, most recently
from
a679cc0
to
f09cd80
Compare
MikelAlejoBR
changed the title
|
/retest |
gwenneg
reviewed
Sep 16, 2024
MikelAlejoBR
force-pushed
the
RHCLOUD-34728-kessel-clients-authorization
branch
from
6cddac3
to
2b14e5d
Compare
Since we are going to introduce another producer, it makes sense to have the producer for the relationships in its own package. Since I was at it, I improved some log messages to make it clear when we are generating clients for the relationships API, and included an explanation at the top of the class clarifying why we implemented our own producers. RHCLOUD-34485
We need a custom producer so that we can produce clients with the "@ApplicationScoped" annotation as otherwise we are not able to mock the clients for the tests. RHCLOUD-34485
Implements the required code to be able to create and delete integrations from Kessel's inventory. RHCLOUD-34485
RHCLOUD-34485
In order to safely talk to Kessel we will need to be using authorized calls by requesting tokens via OIDC. RHCLOUD-34728
Having the Kessel object types in the enumrations helps not having the information scattered around. RHCLOUD-34728
The client libraries we use to talk to Kessel have this dependency as "provided", which makes us have to provide it ourselves instead. RHCLOUD-34728
RHCLOUD-34728
The Kessel team told us that we might want to have them separated to be able to finely control both features at our will, since we might be able to use one of them sooner than the other. RHCLOUD-34728
By allowing to configure the secure channels we won't need to release a new version of Notifications if anything needs to be changed in any of the environments. RHCLOUD-34728
MikelAlejoBR
force-pushed
the
RHCLOUD-34728-kessel-clients-authorization
branch
from
2b14e5d
to
318b670
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
g-duval
pushed a commit
to g-duval/notifications-backend
that referenced
this pull request
Sep 26, 2024
…Insights#2887) * refactor: rename the relationships client producer Since we are going to introduce another producer, it makes sense to have the producer for the relationships in its own package. Since I was at it, I improved some log messages to make it clear when we are generating clients for the relationships API, and included an explanation at the top of the class clarifying why we implemented our own producers. RHCLOUD-34485 * feature: implement an inventory clients producer We need a custom producer so that we can produce clients with the "@ApplicationScoped" annotation as otherwise we are not able to mock the clients for the tests. RHCLOUD-34485 * feature: integration management in Kessel's inventory Implements the required code to be able to create and delete integrations from Kessel's inventory. RHCLOUD-34485 * refactor: remove duplicated "create integration" call RHCLOUD-34485 * feature: auhtenticate Kessel calls In order to safely talk to Kessel we will need to be using authorized calls by requesting tokens via OIDC. RHCLOUD-34728 * refactor: generate object types in the enumeration Having the Kessel object types in the enumrations helps not having the information scattered around. RHCLOUD-34728 * refactor: make the oAuth library available at compile time The client libraries we use to talk to Kessel have this dependency as "provided", which makes us have to provide it ourselves instead. RHCLOUD-34728 * refactor: improve naming consistency RHCLOUD-34728 * refactor: separate Kessel integrations in two toggles The Kessel team told us that we might want to have them separated to be able to finely control both features at our will, since we might be able to use one of them sooner than the other. RHCLOUD-34728 * refactor: remove unused elements from the configuration RHCLOUd-34728 * refactor: allow configuring the secure channels By allowing to configure the secure channels we won't need to release a new version of Notifications if anything needs to be changed in any of the environments. RHCLOUD-34728
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds authentication to the Kessel clients so that our calls are authenticated.
Dependency
Jira ticket
[RHCLOUD-34728]