RHIROS-1345 Probes for processor #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patilsuraj767
requested changes
Sep 18, 2023
clowdapp.yaml
Outdated
| livenessProbe: | ||
| failureThreshold: 3 | ||
| httpGet: | ||
| path: / |
There was a problem hiding this comment.
Here it should be /metrics and not /. Ref - https://github.com/RedHatInsights/ros-ocp-backend/blob/main/internal/utils/utils.go#L183
There was a problem hiding this comment.
Thanks @patilsuraj767, change pushed, do the the config params look fine?
There was a problem hiding this comment.
Config look good for now, Later if we think that there are many http requests coming to the pod we can increase the periodSeconds time.
|
\retest |
saltgen
force-pushed
the
feature/processor-probes
branch
from
ed8f3ea to
94b63d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.