Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #RHIROS-1347 - Dynamically create table partitions to optimize … #127

Merged
merged 10 commits into from
Oct 4, 2023
Merged

Fixes #RHIROS-1347 - Dynamically create table partitions to optimize … #127

merged 10 commits into from
Oct 4, 2023

Conversation

patilsuraj767
Copy link
Collaborator

…DB performance

@patilsuraj767 patilsuraj767 mentioned this pull request Sep 17, 2023
Closed
saltgen
saltgen requested changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@saltgen saltgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patilsuraj767 IIUC, we would need to reset stage db before merging this PR, cause these migrations cannot be run on existing tables?

internal/model/historical_recommendation_set.go Outdated Show resolved Hide resolved
migrations/000004_create_recommendation_sets_table.up.sql Show resolved Hide resolved
kgaikwad
kgaikwad requested changes Sep 22, 2023
View reviewed changes
internal/model/metrics.go Outdated Show resolved Hide resolved
internal/model/workload_metrics.go Outdated Show resolved Hide resolved
kgaikwad
kgaikwad requested changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@kgaikwad kgaikwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added two small nitpicks!

internal/model/historical_recommendation_set.go Outdated Show resolved Hide resolved
internal/model/workload_metrics.go Outdated Show resolved Hide resolved
kgaikwad
kgaikwad requested changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@kgaikwad kgaikwad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patilsuraj767 - you need to replace methods' create_range_patition, create_monthly_patitions calls with create_range_partition & create_monthly_partitions

migrations/000005_partition_functions.up.sql Outdated Show resolved Hide resolved
migrations/000005_partition_functions.up.sql Outdated Show resolved Hide resolved
@patilsuraj767
Copy link
Collaborator Author

/retest

kgaikwad
kgaikwad approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@kgaikwad kgaikwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested. Codewise look good to me.

@patilsuraj767 patilsuraj767 merged commit 480486f into RedHatInsights:main Oct 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saltgen saltgen saltgen approved these changes

@kgaikwad kgaikwad kgaikwad approved these changes

Assignees
No one assigned
Labels
Do not merge Ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patilsuraj767 @kgaikwad @saltgen