RHIROS-1359 Probes for Kruize #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgaikwad
requested changes
Oct 12, 2023
saltgen
force-pushed
the
feature/probes-for-kruize
branch
from
b19f61b to
c445b65
Compare
|
Hello @dgaikwad - could you please look into this and try to test these probes under EE? |
|
/retest |
patilsuraj767
requested changes
Oct 20, 2023
saltgen
force-pushed
the
feature/probes-for-kruize
branch
from
c445b65 to
f687818
Compare
|
@patilsuraj767 All changes pushed |
kgaikwad
previously requested changes
Oct 26, 2023
|
/retest |
saltgen
force-pushed
the
feature/probes-for-kruize
branch
from
f687818 to
6ac7c74
Compare
|
@patilsuraj767 I have also removed the following fields from
|
|
/retest |
patilsuraj767
approved these changes
Nov 1, 2023
|
/retest all |
|
/retest |
|
/retest |
saltgen
added
Ready for review
Ready to merge
and removed
Waiting on contributor
labels
|
msvinaykumar
approved these changes
Jan 24, 2024
saltgen
force-pushed
the
feature/probes-for-kruize
branch
from
2e90ffd to
07bf596
Compare
|
/retest |
- Cleanup of un-used params in create-kruize-partitions
saltgen
force-pushed
the
feature/probes-for-kruize
branch
from
07bf596 to
9148ec6
Compare
|
Changes tested on EE |
|
The PR check failure seems to be cause of performance profile creation failure, I'm able to see recomm on EE. |
|
@kgaikwad I haven't updated the param values post @msvinaykumar's ack on internal IM, hence merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.