RHIROS-1341 Fix sorting for workload type #139
Conversation
Alter constants of enum workloadtype to correct sorting order for workload_type
| upload-msg-to-rosocp: | ||
| echo ${ros_ocp_msg} | docker-compose -f scripts/docker-compose.yml exec -T kafka kafka-console-producer --topic hccm.ros.events --broker-list localhost:29092 | ||
|
|
||
|
|
||
| get-recommendations: | ||
| ifdef env | ||
| $(eval APIPOD=$(shell oc get pods -o custom-columns=POD:.metadata.name --no-headers -n ${env} | grep ros-ocp-backend-api)) | ||
| oc exec ${APIPOD} -c ros-ocp-backend-api -n ${env} -- /bin/bash -c 'curl -s -H "X-Rh-Identity: ${b64_identity}" -H "x-rh-request_id: testtesttest" http://localhost:8000/api/cost-management/v1/recommendations/openshift' | python -m json.tool | ||
| oc exec ${APIPOD} -c ros-ocp-backend-api -n ${env} -- /bin/bash -c 'curl -s -H "X-Rh-Identity: ${b64_identity}" -H "x-rh-request_id: testtesttest" http://localhost:8000/api/cost-management/v1/recommendations/openshift?start_date=2023-04-01' | python -m json.tool |
There was a problem hiding this comment.
Is it possible to not hardcode the start_date? Its my assumption that make file should have a way to pass cmd line arguments and then those can be used?
something like:
make get-recommendations start_date=2023-08-01
There was a problem hiding this comment.
The ros-ocp-usage.csv file we are using to upload data to local kafka topic for processor to upload results to recommendations populated after this date. So, I had faced an issue as a newcomer that I was not able to fetch recommendations because I didn't knew what start date was.
Thanks @upadhyeammit for pointing this out. Maybe @patilsuraj767 has something to add to this?
There was a problem hiding this comment.
@upadhyeammit Feel free to continue, #140 (comment)
| else | ||
| curl -s -H "x-rh-identity: ${b64_identity}" \ | ||
| -H "x-rh-request_id: testtesttest" \ | ||
| http://localhost:8000/api/cost-management/v1/recommendations/openshift | python -m json.tool | ||
| http://localhost:8000/api/cost-management/v1/recommendations/openshift?start_date=2023-04-01 | python -m json.tool |
There was a problem hiding this comment.
Here as well if we can avoid the hardcoding of date?
| @@ -0,0 +1,9 @@ | |||
| ALTER TYPE workloadtype RENAME TO workloadtype_old; | |||
There was a problem hiding this comment.
I was under impression that if we rename the ENUM then table won't be able to reference it or we need to manually change the reference however I can see its updating the name in table as well. So from migration point of view it looks good to me!
There was a problem hiding this comment.
I have followed this article for reference.
|
@srdeotarse Any luck with the PR check failure? |
|
Closing this PR as opened new PR - #140 from forked repo |
Added new migration to alter
workloadtypetype of columnworkloads.workload_typeto correct order of constants inworkloadtypeenumAlso removed
make local-upload-dataand updatedmake get-recommendationsas suggested by @patilsuraj767