Fixes #RHIROS-1402 - Fixed payload creation for kruize updateResult API #142
Conversation
|
/retest |
|
/retest |
| @@ -238,3 +242,19 @@ func ProcessReport(msg *kafka.Message) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| func sliceK8sObjectToChunks(k8s_objects []kruizePayload.UpdateResult) [][]kruizePayload.UpdateResult { | |||
There was a problem hiding this comment.
| func sliceK8sObjectToChunks(k8s_objects []kruizePayload.UpdateResult) [][]kruizePayload.UpdateResult { | |
| func sliceUpdatePayloadToChunks(k8s_objects []kruizePayload.UpdateResult) [][]kruizePayload.UpdateResult { |
There was a problem hiding this comment.
@patilsuraj767 Additionally, I didn't get the reason for moving this function to current file.
There was a problem hiding this comment.
I was getting linting issue because of cyclic imports. So I moved the function out of utils file.
There was a problem hiding this comment.
I think we should try debugging the cyclic import error, in the interest of code maintenance.
There was a problem hiding this comment.
Method signature is changed now we are using kruizePayload.UpdateResult type in the method. So it was not possible to import that types in utils package because utils package(some functions from utils) is already imported in types package.
There was a problem hiding this comment.
We can use Dependency Inversion Principle to resolve this issue, for now I'm unblocking this PR.
There was a problem hiding this comment.
I had a look into Dependency Inversion Principle not sure how it fits in for this case but thanks for unblocking the PR. I will request you if possible you can implement it and create the new PR, will be happy to learn new things.
I referred - https://hackernoon.com/go-design-patterns-an-introduction-to-solid
|
/retest |
|
PR checks are failing because of some unknown issue. This has been reported to the QE team. |
No description provided.