Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kruize image with latest commit #145

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

khansaad
Copy link
Contributor

This PR updates the Kruize image with the latest commit ID.

Signed-off-by: saakhan <saakhan@redhat.com>
@app-sre-bot
Copy link

Can one of the admins verify this patch?

kruize-clowdapp.yaml Outdated Show resolved Hide resolved
Signed-off-by: saakhan <saakhan@redhat.com>
@khansaad khansaad requested a review from kgaikwad October 31, 2023 13:24
Copy link
Collaborator

@kgaikwad kgaikwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@patilsuraj767
Copy link
Collaborator

/retest

@kgaikwad
Copy link
Collaborator

kgaikwad commented Nov 1, 2023

@dgaikwad could you please check and confirm reason behind test pipeline failure? can we ignore test failure? It seems irrelevant to PR change.

application = <iqe.base.application.Application object at 0x7f41b0ae2310>
11:19:59 source_and_upload_data_with_n_days = {'boto3_session_rosocp': (s3.ServiceResource(), <botocore.client.S3 object at 0x7f41aebf91f0>, s3.Bucket(name='ros-eph...314_openshift_report.4.csv?AWSAccessKeyId=sse9T4LPLFA6&Signature=YYan70YFHlWtfUfLk%2F9ziDmmKuE%3D&Expires=1698835762']}
11:19:59 
11:19:59     @pytest.mark.parametrize("n_days_data", [1, 7, 15, 30], indirect=True)
11:19:59     def test_get_recommendation_list(application, source_and_upload_data_with_n_days):
11:19:59         """Test that will test list of ocp recommendations
11:19:59 
11:19:59         GET /api/cost-management/v1/recommendations/openshift/
11:19:59 
11:19:59         metadata:
11:19:59             assignee: dgaikwad
11:19:59             importance: high
11:19:59 
11:19:59         """
11:19:59         if application.config.current_env in ["stage_proxy", "stage", "prod"]:
11:19:59             source_and_upload_data_with_n_days.list_recommendations_by_cluster()
11:19:59         payload = {"_return_http_data_only": False}
11:19:59         response = application.ros_ocp.rest_client.default_api.get_recommendation_list(**payload)
11:19:59         assert response[1] == 200
11:19:59 >       assert response[0].data
11:19:59 E       AssertionError: assert []
11:19:59 E        +  where [] = {'data': [],\n 'links': {'first': '/api/cost-management/v1/recommendations/openshift?limit=10&offset=0',\n           'last': '/api/cost-management/v1/recommendations/openshift?limit=10&offset=10'},\n 'meta': {'count': 0, 'limit': 10, 'offset': 0}}.data
11:19:59 
11:19:59 /iqe_venv/lib/python3.9/site-packages/iqe_ros_ocp/tests/rest/test_endpoints.py:28: AssertionError

@kgaikwad
Copy link
Collaborator

kgaikwad commented Nov 1, 2023

/retest

1 similar comment
@dgaikwad
Copy link

dgaikwad commented Nov 1, 2023

/retest

@dgaikwad
Copy link

dgaikwad commented Nov 1, 2023

@kgaikwad for now we can skip or we can restest it on tomorrow because in the test cases we do not add explicitly start_date in the get recommendation API so today is 1 day of month so not able to process data. As we are getting recommendations when we add the start date so we can skip for today.

@dgaikwad
Copy link

dgaikwad commented Nov 2, 2023

/retest

3 similar comments
@dgaikwad
Copy link

dgaikwad commented Nov 2, 2023

/retest

@kgaikwad
Copy link
Collaborator

kgaikwad commented Nov 3, 2023

/retest

@dgaikwad
Copy link

dgaikwad commented Nov 6, 2023

/retest

@patilsuraj767
Copy link
Collaborator

/retest

1 similar comment
@kgaikwad
Copy link
Collaborator

/retest

@patilsuraj767 patilsuraj767 merged commit 4556751 into RedHatInsights:main Nov 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants