Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(go): add initial Go module #1

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Conversation

ebaron
Copy link
Collaborator

@ebaron ebaron commented Mar 12, 2024

This contains the initial Golang code and tests ported over from the Cryostat Operator. The API to be consumed as a Go module is moved to pkg/insights, while the internal bits stay under internal/controllers.

There will be additional files based on the Operator SDK that will also make this consumable as a container image, but I'll propose that in a separate PR. The Makefile contains some Operator SDK boilerplate that doesn't make sense in the context of this PR, but I included it since the Makefile provides the setup necessary to run the tests with EnvTest. To run them, use make test.

@ebaron ebaron requested a review from csviri March 12, 2024 21:36
Copy link

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor comments. Just one another nitpick, it would be nice to add label selectors (and labels) for informers and objects, so in case of large cluster not every object is cached.

internal/controllers/insights.go Show resolved Hide resolved
internal/controllers/insights.go Show resolved Hide resolved
internal/controllers/insights_controller.go Show resolved Hide resolved
@ebaron ebaron merged commit 981d3e9 into RedHatInsights:main Mar 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants