fix(SystemsPage): RHINENG-5977 - Fix URL params filters handling #2129
Conversation
|
Referenced Jiras: |
bastilian
force-pushed
the
RHINENG-5977
branch
7 times, most recently
from
8edcd8e
to
6811d96
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2129 +/- ##
=======================================
Coverage 67.15% 67.16%
=======================================
Files 128 129 +1
Lines 3440 3441 +1
Branches 1067 1068 +1
=======================================
+ Hits 2310 2311 +1
Misses 1130 1130 ☔ View full report in Codecov by Sentry. |
bastilian
force-pushed
the
RHINENG-5977
branch
from
6811d96
to
20314d9
Compare
bastilian
force-pushed
the
RHINENG-5977
branch
from
20314d9
to
d65a741
Compare
| import { useCallback } from 'react'; | ||
| import { useSearchParams } from 'react-router-dom'; | ||
|
|
||
| // TODO DRY:similar to constructParameters |
There was a problem hiding this comment.
Maybe it is time to finally to implement this TODO. Can we try to consolidate this function with constructParameters and get rid of the duplicate code?
| const [searchParams, setSearchParams] = useSearchParams(); | ||
|
|
||
| const setUrlParams = useCallback((parameters) => { | ||
| const para = constructURLParameters(parameters, allowedParams); |
There was a problem hiding this comment.
NITPICK: It looks like a typo on the first look.
| const para = constructURLParameters(parameters, allowedParams); | |
| const param = constructURLParameters(parameters, allowedParams); |
| describe('MiscHelper', () => { | ||
| it('useUrlParams', async () => { | ||
| const { result } = renderHook(() => useUrlParams(['a', 'b']), { | ||
| wrapper: createTestWrapper(MemoryRouter, { initialEntries: ['/'] }) |
There was a problem hiding this comment.
Can we use the TestWrapper which has already MemortRouter provided?
| @@ -22,4 +22,10 @@ TestWrapper.propTypes = { | |||
| store: propTypes.object | |||
| }; | |||
|
|
|||
| export const createTestWrapper = (Wrapper = TestWrapper, props) => { | |||
There was a problem hiding this comment.
If we use the shared wrapper, this is not needed.
|
@bastilian Just a friendly ping on this :) |
This fixes the issue with filter params and adds them correctly to the URL.
How to test: