Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates e2e tests checkout ref during image publishing #334

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Aug 28, 2024

Description

When rebuilding old images, we need to run the E2E from that references to avoid issues with breaking changes in the CLI. This solution checks out the git repository at the references determined by the trigger and uses the Docker build-push action with a path context.

Fixes #332

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

When rebuilding old images, we need to run the E2E from that
references to avoid issues with breaking changes in the CLI.

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432 jpower432 requested a review from gvauter August 29, 2024 17:34
@jpower432 jpower432 marked this pull request as ready for review August 29, 2024 17:35
@jpower432 jpower432 requested a review from d10n September 4, 2024 18:44
Copy link
Member

@gvauter gvauter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpower432 jpower432 merged commit 5439b91 into main Sep 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E Breaking Changes caused image rebuild failure on schedule trigger
2 participants