Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSCE-237 - Adds Rule YAML to CSV transformation #47

Merged
merged 8 commits into from
Oct 2, 2023
Merged

PSCE-237 - Adds Rule YAML to CSV transformation #47

merged 8 commits into from
Oct 2, 2023

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Sep 27, 2023 •
edited
Loading

Description

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

  • Unit tests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432 jpower432 requested a review from afflom September 27, 2023 22:52
@jpower432 jpower432 mentioned this pull request Sep 30, 2023
Merged
10 tasks
@jpower432
chore: WIP commit for rules transformation
eb91e6f 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
chore: WIP commit with rules transform task type
969ba7b 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
chore: completion of initial CSV Builder
a2eb445 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
chore: adds config creation rule transform task
105e41b 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
feat: adds rule YAML to OSCAL Component Definition transforms
ec06890 
Completes transformation through CSV
Adds RuleTransformer task type

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
docs: updates comments in RuleTransformTask
b71294d 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
chore: moves TrestleRule dataclass to a new file
9a0a530 
Improve error handling
Fixes my linting error

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
chore: adds mypy configutation to pyproject.toml
9a8ab01 
Moves mypy configuration from Makefile to toml file
Fixes addtional issues found by configuration changes

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@afflom afflom merged commit ec5a932 into RedHatProductSecurity:main Oct 2, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afflom afflom Awaiting requested review from afflom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpower432 @afflom