Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSCE-238 #48

Merged
merged 1 commit into from
Oct 3, 2023
Merged

PSCE-238 #48

merged 1 commit into from
Oct 3, 2023

Conversation

afflom
Copy link
Contributor

@afflom afflom commented Sep 29, 2023 •
edited by jpower432
Loading

Description

Adds YAMLBuilder with method for generating Rule template files.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

  • Unit tests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@afflom afflom requested a review from jpower432 September 29, 2023 07:51
jpower432
jpower432 reviewed Sep 29, 2023
View reviewed changes
trestlebot/transformers/csv_to_yaml.py Outdated Show resolved Hide resolved
trestlebot/transformers/csv_to_yaml.py Outdated Show resolved Hide resolved
@afflom afflom force-pushed the PSCE-238 branch 3 times, most recently from eea24d9 to 0fd4f56 Compare October 3, 2023 17:02
@jpower432 jpower432 self-requested a review October 3, 2023 17:28
@afflom
feat(transformer): Add CSV to YAML with empty writer
6fe3026 
Bootstraps component definitions with a rules view
and a template. Also adds class for CSV to YAML
transformations.

Related PSCE-238
Majority of code generated by chatGPT
Signed-off-by: Alex Flom <alexander.flom@gmail.com>
jpower432
jpower432 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpower432 jpower432 merged commit fb1ad0b into RedHatProductSecurity:main Oct 3, 2023
7 checks passed
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpower432 jpower432 jpower432 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afflom @jpower432