Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adds an example row to final CSV to account for skipped rows #58

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix: adds an example row to final CSV to account for skipped rows #58

merged 1 commit into from
Oct 16, 2023

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Oct 12, 2023 •
edited
Loading

Description

The csv_to_oscal_cd task skips the first two rows. The output CSV only had a header row so the first rule was always skipped. This change adds an example row to where the descriptions would be.

Blocked by #55

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

  • Updated unit test

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432 jpower432 changed the title Bug/single rule failure fix: adds an example row to final CSV to account for skipped rows Oct 12, 2023
@jpower432 jpower432 force-pushed the bug/single-rule-failure branch from 4ddc304 to c76b622 Compare October 12, 2023 21:20
@jpower432
fix: adds an example row to final CSV to account for skipped rows
39b6e3e 
The csv_to_oscal_cd task skips the first two rows. The output CSV only had a
header row so the first rule was always skipped. This change adds an example
row to where the descriptions would be.

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432 jpower432 force-pushed the bug/single-rule-failure branch from c76b622 to 39b6e3e Compare October 16, 2023 15:08
@jpower432 jpower432 marked this pull request as ready for review October 16, 2023 15:08
@jpower432 jpower432 requested a review from afflom October 16, 2023 15:09
@afflom afflom merged commit b4998f4 into RedHatProductSecurity:main Oct 16, 2023
7 checks passed
@jpower432 jpower432 deleted the bug/single-rule-failure branch March 26, 2024 13:51
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afflom afflom Awaiting requested review from afflom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpower432 @afflom