Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: normalizes and improves readability for container files #83

Merged
merged 2 commits into from
Nov 30, 2023
Merged

chore: normalizes and improves readability for container files #83

merged 2 commits into from
Nov 30, 2023

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Nov 28, 2023 •
edited
Loading

Description

This adds preparatory changes for adding dev container files. Dev container files will be on a subsequent PR.

Type of change

  • Chore/Maintenance

How has this been tested?

How to Test

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432 jpower432 force-pushed the PSCE-289 branch 2 times, most recently from 5d58741 to c793ad0 Compare November 29, 2023 19:57
@jpower432
chore: updates integration directory to workflows under tests
f41cd32 
Integration is not very precise for the types of tests.
Updates to workflows to reflect that this should test each model path.

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
chore: removes some extra comments in the Containerfile and moves poe…
3bb6a87 
…try envs

Some of the comments are explained by the code so removes to make this more
readable. The poetry environment variables should not be in the base because
poetry is not installed in the final image.

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432 jpower432 marked this pull request as ready for review November 29, 2023 20:05
beatrizmcouto
beatrizmcouto approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@beatrizmcouto beatrizmcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed during sprint planning on Nov 30

@jpower432 jpower432 merged commit 70c8950 into RedHatProductSecurity:main Nov 30, 2023
8 checks passed
@jpower432 jpower432 deleted the PSCE-289 branch March 26, 2024 13:51
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beatrizmcouto beatrizmcouto beatrizmcouto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpower432 @beatrizmcouto