Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds dev container configuration files #84

Merged
merged 1 commit into from
Nov 30, 2023
Merged

feat: adds dev container configuration files #84

merged 1 commit into from
Nov 30, 2023

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Nov 29, 2023 •
edited
Loading

Description

Add dev container configuration and Containerfile.

Due to the need to elevate privileges when running podman in container, this currently does not include support for running the E2E tests with the environment.

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

  • Tested Locally with VSCode
  • Tested with GitHub Codespaces

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432 jpower432 changed the title Psce 289 2 feat: adds dev container configuration files Nov 29, 2023
@jpower432 jpower432 force-pushed the PSCE-289-2 branch 2 times, most recently from a22cf96 to 5e843aa Compare November 29, 2023 20:43
@jpower432
feat: adds custom dev container configuration
42942fe 
Note that this does not having podman installed and
does not support working on or running the end to end
tests.

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432 jpower432 marked this pull request as ready for review November 30, 2023 17:16
beatrizmcouto
beatrizmcouto approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@beatrizmcouto beatrizmcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed during sprint planning Nov 30

@jpower432 jpower432 merged commit 10f93ea into RedHatProductSecurity:main Nov 30, 2023
6 checks passed
@jpower432 jpower432 deleted the PSCE-289-2 branch March 26, 2024 13:51
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beatrizmcouto beatrizmcouto beatrizmcouto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpower432 @beatrizmcouto