feat: updates create_new_with_filter with more filter types and management operations #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
| @@ -246,28 +246,56 @@ def test_create_new_with_filter(tmp_trestle_dir: str) -> None: | |||
| _ = testutils.setup_for_profile(trestle_root, test_prof_filter, test_prof_filter) | |||
|
|
|||
| ssp_name = "new_ssp" | |||
There was a problem hiding this comment.
Consider using os.path.join a comment explaining new directory to be created with ssp name
beatrizmcouto
approved these changes
Dec 6, 2023
…ement operations The create_new_with_filter does not support all of the filter types trestle does. This adds the additional supported types. It also adds optional markdown creation for continued editing. Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Co-authored-by: beatrizmcouto <140717802+beatrizmcouto@users.noreply.github.com>
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
create_new_with_filterdoes not support all of the filter types trestle does. This adds the additional supported types. It also adds optional markdown creation for continued editing.Type of change
No user-facing breaking changes. Though this changes the API
How has this been tested?
Checklist