Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds image tests to CI #92

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Dec 4, 2023

Description

  • Pre-push image scanning
  • Adds optional E2E tests to run after push. Enabled by default with the workflow_dispatch trigger.

Rationale

The workflow dispatch trigger is used on the publish.yml to allow for changes to be validated in the published image.
E2E tests can be run as the first step to check for regressions before conducting further validation.

Blocked by #91
Blocked by #87

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432 jpower432 added enhancement New feature or request ci CI Related work labels Dec 4, 2023
@jpower432 jpower432 force-pushed the PSCE-292 branch 2 times, most recently from 1fa6cda to 703eaf8 Compare December 5, 2023 18:47
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432 jpower432 marked this pull request as ready for review December 5, 2023 21:13
Copy link
Contributor

@beatrizmcouto beatrizmcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed during paired code review on Dec 6

@jpower432 jpower432 merged commit 60e3829 into RedHatProductSecurity:main Dec 6, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI Related work enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants