Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for fenceAgentRemediationTemplate #1869

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Adding support for fenceAgentRemediationTemplate #1869

merged 1 commit into from
Jun 20, 2024

Conversation

geetikakay
Copy link
Contributor

Short description:

support for fenceAgentRemediationTemplate

More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

@redhat-qe-bot
Copy link
Contributor

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
  • To assign reviewers based on OWNERS file use /assign-reviewers
  • To check if PR can be merged use /check-can-merge
Supported /retest check runs
  • /retest tox: Retest tox
  • /retest python-module-install: Retest python-module-install
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@geetikakay
Copy link
Contributor Author

@myakove Hi , pre-commit fails . That's how timeout should be : https://github.com/medik8s/fence-agents-remediation/blob/main/api/v1alpha1/fenceagentsremediation_types.go#L80

myakove
myakove previously approved these changes Jun 13, 2024
View reviewed changes
@geetikakay
Copy link
Contributor Author

/verified

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@geetikakay
Copy link
Contributor Author

/verified

@geetikakay
Copy link
Contributor Author

/verified

@geetikakay
Adding support for fenceAgentRemediationTemplate
899e981 
Signed-off-by: Geetika Kapoor <gkapoor@redhat.com>
@geetikakay
Copy link
Contributor Author

/verified

@geetikakay
Copy link
Contributor Author

@myakove @rnetser Hello, can this be merged. Thanks

@myakove myakove merged commit a91444f into RedHatQE:main Jun 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnetser rnetser rnetser approved these changes

@omrirh omrirh Awaiting requested review from omrirh

@myakove myakove Awaiting requested review from myakove

Assignees
No one assigned
Labels
approved-rnetser branch-main can-be-merged size/M verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@geetikakay @redhat-qe-bot @myakove @rnetser @omrirh @redhat-qe-bot1 @redhat-qe-bot2 @msi-b1