Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Serving Runtime resource #1883

Merged
merged 7 commits into from
Jun 26, 2024
Merged

Conversation

adolfo-ab
Copy link
Contributor

Short description:

Add the ServingRuntime resource.

More details:

Serving Runtimes are used to deploy ML models in OpenShift.

What this PR does / why we need it:

This PR will allow us to handle ServingRuntimes.

Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

@msi-b1
Copy link

msi-b1 commented Jun 18, 2024

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
  • To assign reviewers based on OWNERS file use /assign-reviewers
  • To check if PR can be merged use /check-can-merge
Supported /retest check runs
  • /retest tox: Retest tox
  • /retest python-module-install: Retest python-module-install
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@adolfo-ab
Copy link
Contributor Author

/verified

ocp_resources/serving_runtime.py Outdated Show resolved Hide resolved
ocp_resources/serving_runtime.py Show resolved Hide resolved
ocp_resources/serving_runtime.py Outdated Show resolved Hide resolved
ocp_resources/serving_runtime.py Outdated Show resolved Hide resolved
@adolfo-ab
Copy link
Contributor Author

/verified

@adolfo-ab
Copy link
Contributor Author

/verified

ocp_resources/serving_runtime.py Outdated Show resolved Hide resolved
ocp_resources/serving_runtime.py Show resolved Hide resolved
ocp_resources/serving_runtime.py Outdated Show resolved Hide resolved
ocp_resources/serving_runtime.py Outdated Show resolved Hide resolved
ocp_resources/serving_runtime.py Outdated Show resolved Hide resolved
ocp_resources/serving_runtime.py Outdated Show resolved Hide resolved
ocp_resources/serving_runtime.py Outdated Show resolved Hide resolved
ocp_resources/serving_runtime.py Outdated Show resolved Hide resolved
ocp_resources/serving_runtime.py Outdated Show resolved Hide resolved
@adolfo-ab
Copy link
Contributor Author

/verified

@myakove
Copy link
Collaborator

myakove commented Jun 26, 2024

/lgtm

@myakove
Copy link
Collaborator

myakove commented Jun 26, 2024

/verified

@myakove
Copy link
Collaborator

myakove commented Jun 26, 2024

/check-can-merge

@myakove myakove merged commit 7ce8890 into RedHatQE:main Jun 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants