Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeoutSampler exceptions arg deprecation for Resource get() retry #24

Merged
merged 1 commit into from
Aug 10, 2021
Merged

TimeoutSampler exceptions arg deprecation for Resource get() retry #24

merged 1 commit into from
Aug 10, 2021

Conversation

sarahbx
Copy link
Contributor

@sarahbx sarahbx commented Jul 6, 2021 •
edited 

    TimeoutSampler exceptions arg deprecation for Resource get() retry
    
    TimeoutSampler:
    - Deprecated: 'exceptions' and 'exceptions_msg' arguments will be removed
    - New: exceptions_dict argument to handle additional exception states
    
    Resource:
    - Changed: additional exception states retried in get() to increase resiliency

@rnetser rnetser requested a review from myakove July 6, 2021 13:12
rnetser
rnetser reviewed Jul 11, 2021
View reviewed changes
ocp_resources/utils.py Outdated Show resolved Hide resolved
myakove
myakove requested changes Jul 13, 2021
View reviewed changes
ocp_resources/utils.py Outdated Show resolved Hide resolved
rnetser
rnetser reviewed Jul 21, 2021
View reviewed changes
ocp_resources/utils.py Outdated Show resolved Hide resolved
@sarahbx sarahbx force-pushed the default_retry_exceptions branch 2 times, most recently from 4116f4d to 7a1f40f Compare July 21, 2021 13:58
@sarahbx sarahbx marked this pull request as draft July 21, 2021 21:09
@sarahbx
Copy link
Contributor Author

sarahbx commented Jul 21, 2021

Moved to draft temporarily. I am going to add a test for _process_execution() before we continue with this change.

@sarahbx sarahbx mentioned this pull request Jul 21, 2021
Closed
@sarahbx
Copy link
Contributor Author

sarahbx commented Jul 21, 2021

After #53 is merged, will update unit test for _process_execution to run _process_exceptions with additional test cases.

myakove
myakove requested changes Jul 22, 2021
View reviewed changes
ocp_resources/utils.py Outdated Show resolved Hide resolved
ocp_resources/utils.py Outdated Show resolved Hide resolved
ocp_resources/utils.py Outdated Show resolved Hide resolved
ocp_resources/utils.py Outdated Show resolved Hide resolved
ocp_resources/utils.py Outdated Show resolved Hide resolved
ocp_resources/utils.py Outdated Show resolved Hide resolved
ocp_resources/utils.py Outdated Show resolved Hide resolved
myakove
myakove requested changes Jul 22, 2021
View reviewed changes
tests/test_utils.py Outdated Show resolved Hide resolved
myakove
myakove requested changes Jul 22, 2021
View reviewed changes
tests/test_utils.py Outdated Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
myakove
myakove requested changes Jul 22, 2021
View reviewed changes
tests/test_utils.py Outdated Show resolved Hide resolved
@myakove myakove removed the Size:L label Jul 26, 2021
@sarahbx sarahbx force-pushed the default_retry_exceptions branch 7 times, most recently from 973123b to bd51fd7 Compare July 27, 2021 18:41
sarahbx
sarahbx commented Aug 3, 2021
View reviewed changes
ocp_resources/utils.py Outdated Show resolved Hide resolved
@sarahbx sarahbx force-pushed the default_retry_exceptions branch 2 times, most recently from 71246eb to bbd208e Compare August 3, 2021 22:03
@cnv-qe-bot cnv-qe-bot requested a review from rnetser August 4, 2021 07:05
@sarahbx sarahbx force-pushed the default_retry_exceptions branch 2 times, most recently from 009be70 to c76c642 Compare August 4, 2021 21:12
@cnv-qe-bot cnv-qe-bot requested a review from AdiZav August 5, 2021 17:50
@myakove myakove added this to Review in progress in openshift-python-wrapper Aug 8, 2021
myakove
myakove reviewed Aug 8, 2021
View reviewed changes
Copy link
Collaborator

@myakove myakove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few small comments, otherwise looks good.

.github/workflows/code-check.yml Outdated Show resolved Hide resolved
ocp_resources/utils.py Outdated Show resolved Hide resolved
ocp_resources/utils.py Show resolved Hide resolved
@cnv-qe-bot cnv-qe-bot requested a review from myakove August 9, 2021 14:51
@ibesso-rh
Copy link
Contributor

@sarahbx , could you please process/absorb the final result following all the comments i got on my PR (strictly docstring PR)?
#37

I'm closing that one now.

@sarahbx
TimeoutSampler exceptions arg deprecation for Resource get() retry
2b00ccc 
TimeoutSampler:
- Deprecated: 'exceptions' and 'exceptions_msg' arguments will be removed
- New: exceptions_dict argument to handle additional exception states

Resource:
- Changed: additional exception states retried in get() to increase resiliency
openshift-python-wrapper automation moved this from Review in progress to Reviewer approved Aug 10, 2021
@myakove myakove merged commit ad08aff into RedHatQE:master Aug 10, 2021
openshift-python-wrapper automation moved this from Reviewer approved to Done Aug 10, 2021
@sarahbx sarahbx deleted the default_retry_exceptions branch August 11, 2021 17:16
@ibesso-rh ibesso-rh mentioned this pull request Aug 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myakove myakove myakove approved these changes

@rnetser rnetser Awaiting requested review from rnetser

@AdiZav AdiZav Awaiting requested review from AdiZav

Assignees

@myakove myakove

Labels
None yet
Projects
No open projects
openshift-python-wrapper
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sarahbx @kubevirt-bot @ibesso-rh @myakove @rnetser @cnv-qe-bot