-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDI resource is not Namespace resource #82
Conversation
/approve |
""" | ||
CDI object. | ||
""" | ||
|
||
api_group = NamespacedResource.ApiGroup.CDI_KUBEVIRT_IO | ||
api_group = Resource.ApiGroup.CDI_KUBEVIRT_IO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be updated across the wrapper, there are additional places this ApiGroup
is referenced as a NamespacedResource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarahbx what do you mean?
each resource call his parent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does due to inheritance, but this is confusing for cluster scoped resources, using both to refer to a non-namespace scoped resource.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ultimately, we should remove this inheritance for ApiGroup so they must be defined in one or the other
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ibesso-rh, rnetser The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Short description:
CDI resource is not Namespace resource and should inherit from Resource.
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:
Release notes: