Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDI resource is not Namespace resource #82

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

myakove
Copy link
Collaborator

@myakove myakove commented Aug 3, 2021

Short description:

CDI resource is not Namespace resource and should inherit from Resource.

More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:
Release notes:
None

@rnetser
Copy link
Collaborator

rnetser commented Aug 3, 2021

/approve

"""
CDI object.
"""

api_group = NamespacedResource.ApiGroup.CDI_KUBEVIRT_IO
api_group = Resource.ApiGroup.CDI_KUBEVIRT_IO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated across the wrapper, there are additional places this ApiGroup is referenced as a NamespacedResource

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarahbx what do you mean?
each resource call his parent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does due to inheritance, but this is confusing for cluster scoped resources, using both to refer to a non-namespace scoped resource.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultimately, we should remove this inheritance for ApiGroup so they must be defined in one or the other

@myakove
Copy link
Collaborator Author

myakove commented Aug 3, 2021

cdi = list(CDI.get(dyn_client=admin_client))
[<ocp_resources.cdi.CDI object at 0x7f21c03f4160>]
cdi[0].name
'cdi-kubevirt-hyperconverged'

@ibesso-rh
Copy link
Contributor

/approve
ran tests that failed before.

@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibesso-rh, rnetser

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@myakove myakove merged commit 9f58b38 into RedHatQE:master Aug 3, 2021
@myakove myakove deleted the cdi-from-Resource branch August 3, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants