Small improvement for snake case handling #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @IljaKosynkin! I've added tests for func testSnakeCase() throws {
...
XCTAssertEqual("Icon=WIFI 24".snakeCased(), "icon_wifi_24")
...
} |
|
When you add test I can merge your PR. |
IljaKosynkin
force-pushed
the
better-snake-case
branch
from
24b5c38
to
1150798
Compare
|
Sorry, @subdan got caught up in work. Added tests |
subdan
approved these changes
Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good time of the day!
I created a small improvement to the way snake case is handled. Right now if you have (for instance) "Icon=WIFI 24" it will be translated into "icon_w_i_f_i_24". With this update it will be "icon_wifi_24", which, I think, is better.
I'm not sure about tests though, haven't found any for this function. Any pointers?