Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Support RTL #180

Merged
merged 6 commits into from
Jul 14, 2022
Merged

[iOS] Support RTL #180

merged 6 commits into from
Jul 14, 2022

Conversation

alexey1312
Copy link
Contributor

From discussions #133

subdan
subdan requested changes Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@subdan subdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add info about supporting RTL to the README.md.

Sources/FigmaExport/Loaders/ImagesLoader.swift Outdated Show resolved Hide resolved
@subdan
Copy link
Collaborator

subdan commented Jul 13, 2022

Hi, @alexey1312. Thanks for the PR! Will you use this feature in your project?

@alexey1312
Update ImagesLoader
b087d93 
localizedCaseInsensitiveContains
@alexey1312
Update README
6055f29
@alexey1312
Copy link
Contributor Author

Hi, @alexey1312. Thanks for the PR! Will you use this feature in your project?

Hi! Yes, we will 🚀
We know about the problem, but I tested the solution above, it works well.

Maybe in the future, it's worth adding Stencil Templates, with .flipsForRightToLeftLayoutDirection(true) for icons.

@alexey1312 alexey1312 requested a review from subdan July 14, 2022 03:59
subdan
subdan reviewed Jul 14, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@alexey1312 alexey1312 requested a review from subdan July 14, 2022 18:27
@subdan subdan merged commit f2321f1 into RedMadRobot:master Jul 14, 2022
@alexey1312 alexey1312 deleted the feature/SupportRTLForIOS branch July 15, 2022 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subdan subdan Awaiting requested review from subdan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexey1312 @subdan