Add xmlOutputFileName for androidConfig.colors #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is difficult to integrate figma-export into already written project. It usually has own colors.xml file with project-specific color-resources. And figma-export ouput is hardcorded into colors.xml, so it will conflict with already written file colors.xml. This PR adds optional field to setup output file name (only for colors and only for XML)
Also, devs will ruin autogenerated file cause they already habits to edit colors.xml (I guess autogenerated file should have name like "colors_autogenerated.xml")