refactor: use effect syntax from OCaml 5.3 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsterling
reviewed
Oct 2, 2024
| | _ -> None } | ||
| try f () with | ||
| | effect Get, k -> continue k !st | ||
| | effect Set v, k -> st := v; continue k () | ||
|
|
||
| let try_with ?(get=get) ?(set=set) f = | ||
| let open Effect.Deep in |
There was a problem hiding this comment.
Is open Effect.Deep needed anymore?
There was a problem hiding this comment.
@jonsterling Yes. See ocaml/ocaml#13511 for my Thought on this.
There was a problem hiding this comment.
@jonsterling It's also why we have these two helper functions:
https://github.com/RedPRL/algaeff/blob/main/src/Fun.ml
It will be great if the compiler can do it directly, avoiding the overhead of creating stupid closures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.