Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support RETURN AS in SEARCH #119

Merged
merged 27 commits into from
Jul 27, 2021
Merged

Support RETURN AS in SEARCH #119

merged 27 commits into from
Jul 27, 2021

Conversation

AvitalFineRedis
Copy link
Contributor

No description provided.

@AvitalFineRedis AvitalFineRedis marked this pull request as ready for review July 18, 2021 15:31
@AvitalFineRedis AvitalFineRedis assigned chayim and unassigned chayim Jul 19, 2021
@AvitalFineRedis AvitalFineRedis linked an issue Jul 21, 2021 that may be closed by this pull request
Add support for JSON type Index #110
Closed
@codecov
Copy link

codecov bot commented Jul 21, 2021 •
edited
Loading

Codecov Report

Merging #119 (179d250) into master (e0864a7) will decrease coverage by 0.35%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   77.87%   77.52%   -0.36%     
==========================================
  Files          13       13              
  Lines        1320     1326       +6     
==========================================
  Hits         1028     1028              
- Misses        232      238       +6     
  Partials       60       60
Impacted Files Coverage Δ
redisearch/query.go 82.68% <0.00%> (-2.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0864a7...179d250. Read the comment docs.

@AvitalFineRedis
Copy link
Contributor Author

@chayim Why the codecov says I didn't cover these methods?

chayim
chayim reviewed Jul 27, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
chayim
chayim reviewed Jul 27, 2021
View reviewed changes
Makefile Outdated
@docker run --name redisearch-go-tests -d --rm -p 6379:6379 redislabs/redisearch:edge

stop-redis:
@docker stop redisearch-go-tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dockername in variable

chayim
chayim suggested changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny changes requested.

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AvitalFineRedis AvitalFineRedis merged commit bd0b1c1 into master Jul 27, 2021
@AvitalFineRedis AvitalFineRedis deleted the support_return_as branch July 27, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chayim chayim chayim approved these changes

@filipecosta90 filipecosta90 Awaiting requested review from filipecosta90

Assignees

@chayim chayim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for JSON type Index
4 participants
@AvitalFineRedis @chayim @rafie @gkorland