Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FT.CONFIG command #50

Merged
merged 1 commit into from
Apr 5, 2020
Merged

Conversation

dengliming
Copy link
Contributor

@dengliming dengliming commented Apr 4, 2020

A PR for #44

@codecov
Copy link

codecov bot commented Apr 4, 2020

Codecov Report

Merging #50 into master will increase coverage by 4.41%.
The diff coverage is 69.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   68.10%   72.52%   +4.41%     
==========================================
  Files          12       12              
  Lines         925     1059     +134     
==========================================
+ Hits          630      768     +138     
+ Misses        239      232       -7     
- Partials       56       59       +3     
Impacted Files Coverage Δ
redisearch/pool.go 85.71% <0.00%> (+54.67%) ⬆️
redisearch/schema.go 75.55% <ø> (ø)
redisearch/suggest.go 0.00% <ø> (ø)
redisearch/autocomplete.go 55.67% <44.44%> (+1.50%) ⬆️
redisearch/query.go 74.87% <62.24%> (-11.36%) ⬇️
redisearch/document.go 72.58% <72.41%> (-0.15%) ⬇️
redisearch/client.go 79.12% <89.62%> (+11.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e48e5d...9817666. Read the comment docs.

@filipecosta90 filipecosta90 self-requested a review April 4, 2020 19:10
@dengliming
Copy link
Contributor Author

@filipecosta90 Thanks. Is there anything else need to be done?

@filipecosta90
Copy link
Collaborator

@filipecosta90 Thanks. Is there anything else need to be done?

Merging @dengliming . Thank you 👍

@filipecosta90 filipecosta90 merged commit 910ef02 into RediSearch:master Apr 5, 2020
@filipecosta90 filipecosta90 mentioned this pull request Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants