Added support for SLOP #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se SLOP 0 is a valid activity.
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
==========================================
- Coverage 76.77% 76.63% -0.14%
==========================================
Files 13 13
Lines 1098 1100 +2
==========================================
Hits 843 843
- Misses 198 199 +1
- Partials 57 58 +1
Continue to review full report at Codecov.
|
rafie
approved these changes
Apr 11, 2021
|
@devinsburke can we add a test for it? |
filipecosta90
added
the
state:needs-test-pr
|
Kudos, SonarCloud Quality Gate passed!
|
filipecosta90
approved these changes
Apr 22, 2021
|
Merged @devinsburke . Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for SLOP. Changed the int to an *int pointer (nullable) because SLOP 0 is a valid activity. The existing slop int attribute of the query struct was completely unused/unreferenced previously.